Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Venafi broken link #1270

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Fix Venafi broken link #1270

merged 1 commit into from
Aug 10, 2023

Conversation

ushuz
Copy link
Contributor

@ushuz ushuz commented Aug 9, 2023

The original link returns 404. This PR updated the link to a working one.

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2023
@netlify
Copy link

netlify bot commented Aug 9, 2023 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 64d7c24
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64d3ce4fb1517e0008064137
😎 Deploy Preview https://deploy-preview-1270--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ushuz
Fix venafi link 404
64d7c24 
Signed-off-by: John HU <[email protected]>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Aug 9, 2023
SgtCoDFish
SgtCoDFish approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks so much for this, really appreciate this kind of quick fix ❤️

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, ushuz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@SgtCoDFish SgtCoDFish merged commit 6805d40 into cert-manager:master Aug 10, 2023
1 check passed
@ushuz ushuz deleted the patch-1 branch August 10, 2023 16:21
@jetstack-bot jetstack-bot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ushuz @jetstack-bot @SgtCoDFish